Skip to content

boards: renesas: Add support MCUBoot for ek_ra8p1 and mck_ra8t2 #97842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2025
Merged

boards: renesas: Add support MCUBoot for ek_ra8p1 and mck_ra8t2 #97842

merged 3 commits into from
Oct 23, 2025

Conversation

@khoa-nguyen-18
Copy link
Contributor

@khoa-nguyen-18 khoa-nguyen-18 commented Oct 18, 2025

  • Add depend on BOOTLOADER_MCUBOOT for SOC_RA_ENABLE_START_SECOND_CORE config
  • Add support MCUBoot for ek_ra8p1 and mck_ra8t2
  • Remove storage_partition definition for Renesas ek_ra8p1, mck_ra8t2 in the test flash/common

@khoa-nguyen-18 khoa-nguyen-18 added this to the v4.3.0 milestone Oct 18, 2025
@github-actions
Copy link

github-actions bot commented Oct 18, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
hal_renesas zephyrproject-rtos/hal_renesas@f6950ff zephyrproject-rtos/hal_renesas@fbe4b81 (main) zephyrproject-rtos/[email protected]

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@github-actions github-actions bot added manifest manifest-hal_renesas DNM (manifest) This PR should not be merged (controlled by action-manifest) labels Oct 18, 2025
@zephyrbot zephyrbot added area: Boards/SoCs platform: Renesas Renesas platform: Renesas RA Renesas Electronics Corporation, RA area: Flash area: Tests Issues related to a particular existing or missing test labels Oct 18, 2025
JarmouniA
JarmouniA reviewed Oct 18, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add info about MCUboot usage to the board doc? Also, add Kconfig.sysbuild to board folder with the following

choice BOOTLOADER
	default BOOTLOADER_MCUBOOT
endchoice

@khoa-nguyen-18 khoa-nguyen-18 force-pushed the support_renesas_ra8x2_mcuboot branch from ed85ac9 to bb5316e Compare October 22, 2025 08:11
@khoa-nguyen-18
Copy link
Contributor Author

khoa-nguyen-18 commented Oct 22, 2025

Can you add info about MCUboot usage to the board doc? Also, add Kconfig.sysbuild to board folder with the following

choice BOOTLOADER
	default BOOTLOADER_MCUBOOT
endchoice

Many thanks for your suggestion and the reference. I’ve added the board documentation for MCUboot. However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot. Instead, we guide users to build with the additional configuration option -DSB_CONFIG_BOOTLOADER_MCUBOOT=y.

thenguyenyf
thenguyenyf previously approved these changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@thenguyenyf thenguyenyf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will revisit after manifest is merged

JarmouniA
JarmouniA previously requested changes Oct 22, 2025
View reviewed changes
Copy link
Contributor

@JarmouniA JarmouniA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You still need to add Kconfig.sysbuild file. (Non-blocking)
Apply remarks to both boards.

@JarmouniA
Copy link
Contributor

JarmouniA commented Oct 22, 2025

However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot

Those should be the exception, not the general default. Also, you can create a dedicated board variant for those.

@duynguyenxa
Copy link
Member

duynguyenxa commented Oct 22, 2025

Can you add info about MCUboot usage to the board doc? Also, add Kconfig.sysbuild to board folder with the following

choice BOOTLOADER
	default BOOTLOADER_MCUBOOT
endchoice

Many thanks for your suggestion and the reference. I’ve added the board documentation for MCUboot. However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot. Instead, we guide users to build with the additional configuration option -DSB_CONFIG_BOOTLOADER_MCUBOOT=y.

However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot

Those should be the exception, not the general default. Also, you can create a dedicated board variant for those.

Hi @nordicjm, @kartben — could we get your thoughts on this?
Should there be a Kconfig.sysbuild default here for MCUboot for the board, or should we leave it out to keep sysbuild generic for both MCUboot and non-MCUboot applications?

@nordicjm
Copy link
Contributor

nordicjm commented Oct 22, 2025

Can you add info about MCUboot usage to the board doc? Also, add Kconfig.sysbuild to board folder with the following

choice BOOTLOADER
	default BOOTLOADER_MCUBOOT
endchoice

Many thanks for your suggestion and the reference. I’ve added the board documentation for MCUboot. However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot. Instead, we guide users to build with the additional configuration option -DSB_CONFIG_BOOTLOADER_MCUBOOT=y.

However, I prefer not to include Kconfig.sysbuild in this case, as it’s specific to the user’s build setup. We also need sysbuild to support building other applications that don’t use or require MCUboot

Those should be the exception, not the general default. Also, you can create a dedicated board variant for those.

Hi @nordicjm, @kartben — could we get your thoughts on this? Should there be a Kconfig.sysbuild default here for MCUboot for the board, or should we leave it out to keep sysbuild generic for both MCUboot and non-MCUboot applications?

MCUboot is optional. You can build an application for the board without MCUboot and it builds, flashes and runs fine right? So having MCUboot disabled by default is perfectly fine

nordicjm
nordicjm reviewed Oct 22, 2025
View reviewed changes
boards/renesas/ek_ra8p1/doc/index.rst
west flash -r jlink
MCUboot bootloader
Copy link
Contributor

@nordicjm nordicjm Oct 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this information applies to any board and it seems like good information to have but to have it globally rather than multiple times in different boards - which also means it's easier to maintain updating once then X times in boards - thoughts @kartben ?

Copy link
Contributor

@kartben kartben Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 -- would suggest adding an rst "snippet" boards/common/doc and the .. literalinclude it wherever needed

@khoa-nguyen-18
manifest: Update hal_renesas revision to get MCUBoot support
7b7ef94 
Update hal_renesas revision to get MCUBoot support

Signed-off-by: Khoa Nguyen <[email protected]>
@khoa-nguyen-18
boards: renesas: Add support MCUBoot for ek_ra8p1 and mck_ra8t2
8ec10be 
Add support MCUBoot for ek_ra8p1 and mck_ra8t2

Signed-off-by: Khoa Nguyen <[email protected]>
@khoa-nguyen-18
tests: drivers: flash: common: Remove storage_partition definition
82c35a5 
Remove storage_partition definition for Renesas ek_ra8p1, mck_ra8t2

Signed-off-by: Khoa Nguyen <[email protected]>
@khoa-nguyen-18 khoa-nguyen-18 force-pushed the support_renesas_ra8x2_mcuboot branch from bb5316e to 82c35a5 Compare October 23, 2025 08:04
@github-actions github-actions bot removed the DNM (manifest) This PR should not be merged (controlled by action-manifest) label Oct 23, 2025
@khoa-nguyen-18
Copy link
Contributor Author

khoa-nguyen-18 commented Oct 23, 2025

  • Rebase main to solve conflicts
  • Update hal_renesas revision since the HAL PR has been merged
  • Update typos and add missing MCUboot information in the board documentation based on feedback comments

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JarmouniA JarmouniA dismissed their stale review October 23, 2025 08:22

addressed

thaoluonguw
thaoluonguw approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@thaoluonguw thaoluonguw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@kartben kartben merged commit e5e1edd into zephyrproject-rtos:main Oct 23, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben left review comments

@nordicjm nordicjm nordicjm left review comments

@JarmouniA JarmouniA JarmouniA left review comments

@KhiemNguyenT KhiemNguyenT KhiemNguyenT approved these changes

@thaoluonguw thaoluonguw thaoluonguw approved these changes

@thenguyenyf thenguyenyf thenguyenyf approved these changes

@andrzej-kaczmarek andrzej-kaczmarek Awaiting requested review from andrzej-kaczmarek

@binhnguyen2434 binhnguyen2434 Awaiting requested review from binhnguyen2434

@blauret blauret Awaiting requested review from blauret

@de-nordic de-nordic Awaiting requested review from de-nordic

@duynguyenxa duynguyenxa Awaiting requested review from duynguyenxa

@ioannis-karachalios ioannis-karachalios Awaiting requested review from ioannis-karachalios

@nashif nashif Awaiting requested review from nashif

@nhutnguyenkc nhutnguyenkc Awaiting requested review from nhutnguyenkc

@rghaddab rghaddab Awaiting requested review from rghaddab

@soburi soburi Awaiting requested review from soburi

@ydamigos ydamigos Awaiting requested review from ydamigos

Assignees

@soburi soburi

@KhiemNguyenT KhiemNguyenT

Labels

area: Boards/SoCs area: Flash area: Tests Issues related to a particular existing or missing test manifest manifest-hal_renesas platform: Renesas RA Renesas Electronics Corporation, RA platform: Renesas Renesas

Projects

None yet

Milestone

v4.3.0

Development

Successfully merging this pull request may close these issues.

10 participants

@khoa-nguyen-18 @JarmouniA @duynguyenxa @nordicjm @kartben @KhiemNguyenT @thaoluonguw @thenguyenyf @soburi @zephyrbot